Skip to content

Commit

Permalink
rebase -i: create .dotest-merge after validating options.
Browse files Browse the repository at this point in the history
Creating .dotest-merge before validating the options prevents both
--continue and --interactive from working if the options are invalid,
so only create it after validating the options.

[jc: however, just moving the creation of DOTEST breaks output]

Signed-off-by: Matt Kraai <kraai@ftbfs.org>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Matt Kraai authored and Junio C Hamano committed Sep 26, 2007
1 parent ae830ed commit 5166810
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions git-rebase--interactive.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,9 @@ warn () {
output () {
case "$VERBOSE" in
'')
"$@" > "$DOTEST"/output 2>&1
output=$("$@" 2>&1 )
status=$?
test $status != 0 &&
cat "$DOTEST"/output
test $status != 0 && printf "%s\n" "$output"
return $status
;;
*)
Expand Down Expand Up @@ -428,7 +427,6 @@ do

require_clean_work_tree

mkdir "$DOTEST" || die "Could not create temporary $DOTEST"
if test ! -z "$2"
then
output git show-ref --verify --quiet "refs/heads/$2" ||
Expand All @@ -440,6 +438,8 @@ do
HEAD=$(git rev-parse --verify HEAD) || die "No HEAD?"
UPSTREAM=$(git rev-parse --verify "$1") || die "Invalid base"

mkdir "$DOTEST" || die "Could not create temporary $DOTEST"

test -z "$ONTO" && ONTO=$UPSTREAM

: > "$DOTEST"/interactive || die "Could not mark as interactive"
Expand Down

0 comments on commit 5166810

Please sign in to comment.