Skip to content

Commit

Permalink
gitk: Improve appearance of radiobuttons and checkbuttons
Browse files Browse the repository at this point in the history
Commit 5497f7a ("gitk: Add configuration
for UI colour scheme") added a call to tk_setPalette at startup.
Unfortunately, tk_setPalette always chooses a dark red color for
the selectColor value if none is given explicitly, and this makes
checkbuttons and radiobuttons look rather bad.

This restores the previous appearance by specifying selectColor
explicitly.  For light backgrounds we use white for selectColor, and
for dark backgrounds we use black.  The formula and threshold for
distinguishing light from dark are the same as used in tk_setPalette
for choosing the foreground color.

Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Paul Mackerras committed Nov 14, 2009
1 parent 8d84995 commit 51a7e8b
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions gitk
Original file line number Diff line number Diff line change
Expand Up @@ -10596,8 +10596,18 @@ proc setselbg {c} {
allcanvs itemconf secsel -fill $c
}

# This sets the background color and the color scheme for the whole UI.
# For some reason, tk_setPalette chooses a nasty dark red for selectColor
# if we don't specify one ourselves, which makes the checkbuttons and
# radiobuttons look bad. This chooses white for selectColor if the
# background color is light, or black if it is dark.
proc setui {c} {
tk_setPalette $c
set bg [winfo rgb . $c]
set selc black
if {[lindex $bg 0] + 1.5 * [lindex $bg 1] + 0.5 * [lindex $bg 2] > 100000} {
set selc white
}
tk_setPalette background $c selectColor $selc
}

proc setbg {c} {
Expand Down Expand Up @@ -11159,7 +11169,7 @@ eval font create textfontbold [fontflags textfont 1]
parsefont uifont $uifont
eval font create uifont [fontflags uifont]

tk_setPalette $uicolor
setui $uicolor

setoptions

Expand Down

0 comments on commit 51a7e8b

Please sign in to comment.