Skip to content

Commit

Permalink
setup_revisions(): do not call get_pathspec() too early
Browse files Browse the repository at this point in the history
This is necessary because we will later allow pathspecs to be fed from the
standard input, and pathspecs taken from the command line (and converted
via get_pathspec() already) in revs->prune_data too early gets in the way
when we want to append from the standard input.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Nov 20, 2009
1 parent 8b3dce5 commit 5486ef0
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions revision.c
Original file line number Diff line number Diff line change
Expand Up @@ -1230,6 +1230,7 @@ void parse_revision_opt(struct rev_info *revs, struct parse_opt_ctx_t *ctx,
int setup_revisions(int argc, const char **argv, struct rev_info *revs, const char *def)
{
int i, flags, left, seen_dashdash, read_from_stdin;
const char **prune_data = NULL;

/* First, search for "--" */
seen_dashdash = 0;
Expand All @@ -1240,7 +1241,7 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
argv[i] = NULL;
argc = i;
if (argv[i + 1])
revs->prune_data = get_pathspec(revs->prefix, argv + i + 1);
prune_data = argv + i + 1;
seen_dashdash = 1;
break;
}
Expand Down Expand Up @@ -1321,12 +1322,14 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
for (j = i; j < argc; j++)
verify_filename(revs->prefix, argv[j]);

revs->prune_data = get_pathspec(revs->prefix,
argv + i);
prune_data = argv + i;
break;
}
}

if (prune_data)
revs->prune_data = get_pathspec(revs->prefix, prune_data);

if (revs->def == NULL)
revs->def = def;
if (revs->show_merge)
Expand Down

0 comments on commit 5486ef0

Please sign in to comment.