Skip to content

Commit

Permalink
Merge branch 'jc/push-2.0-default-to-simple' (early part)
Browse files Browse the repository at this point in the history
Adjust our tests for upcoming migration of the default value for the
"push.default" configuration variable to "simple" from "mixed".

* 'jc/push-2.0-default-to-simple' (early part):
  t5570: do not assume the "matching" push is the default
  t5551: do not assume the "matching" push is the default
  t5550: do not assume the "matching" push is the default
  t9401: do not assume the "matching" push is the default
  t9400: do not assume the "matching" push is the default
  t7406: do not assume the "matching" push is the default
  t5531: do not assume the "matching" push is the default
  t5519: do not assume the "matching" push is the default
  t5517: do not assume the "matching" push is the default
  t5516: do not assume the "matching" push is the default
  t5505: do not assume the "matching" push is the default
  t5404: do not assume the "matching" push is the default
  • Loading branch information
Junio C Hamano committed Apr 18, 2013
2 parents 8dd2858 + ac47a22 commit 54a3c67
Show file tree
Hide file tree
Showing 12 changed files with 24 additions and 16 deletions.
2 changes: 1 addition & 1 deletion t/t5404-tracking-branches.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ test_expect_success 'prepare pushable branches' '
'

test_expect_success 'mixed-success push returns error' '
test_must_fail git push
test_must_fail git push origin :
'

test_expect_success 'check tracking branches updated correctly after push' '
Expand Down
2 changes: 1 addition & 1 deletion t/t5505-remote.sh
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ test_expect_success 'fetch mirrors do not act as mirrors during push' '
) &&
(cd mirror-fetch/child &&
git branch -m renamed renamed2 &&
git push parent
git push parent :
) &&
(cd mirror-fetch/parent &&
git rev-parse --verify renamed &&
Expand Down
12 changes: 7 additions & 5 deletions t/t5516-fetch-push.sh
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ test_expect_success 'push with pushInsteadOf and explicit pushurl (pushInsteadOf
test_expect_success 'push with matching heads' '
mk_test testrepo heads/master &&
git push testrepo &&
git push testrepo : &&
check_push_result testrepo $the_commit heads/master
'
Expand Down Expand Up @@ -281,7 +281,7 @@ test_expect_success 'push --force with matching heads' '
mk_test testrepo heads/master &&
git push testrepo : &&
git commit --amend -massaged &&
git push --force testrepo &&
git push --force testrepo : &&
! check_push_result testrepo $the_commit heads/master &&
git reset --hard $the_commit
Expand Down Expand Up @@ -504,6 +504,7 @@ test_expect_success 'push with remote.pushdefault' '
test_config remote.down.url down_repo &&
test_config branch.master.remote up &&
test_config remote.pushdefault down &&
test_config push.default matching &&
git push &&
check_push_result up_repo $the_first_commit heads/master &&
check_push_result down_repo $the_commit heads/master
Expand All @@ -515,7 +516,7 @@ test_expect_success 'push with config remote.*.pushurl' '
git checkout master &&
test_config remote.there.url test2repo &&
test_config remote.there.pushurl testrepo &&
git push there &&
git push there : &&
check_push_result testrepo $the_commit heads/master
'

Expand All @@ -528,6 +529,7 @@ test_expect_success 'push with config branch.*.pushremote' '
test_config remote.down.url down_repo &&
test_config branch.master.remote up &&
test_config branch.master.pushremote down &&
test_config push.default matching &&
git push &&
check_push_result up_repo $the_first_commit heads/master &&
check_push_result side_repo $the_first_commit heads/master &&
Expand All @@ -541,7 +543,7 @@ test_expect_success 'push with dry-run' '
cd testrepo &&
old_commit=$(git show-ref -s --verify refs/heads/master)
) &&
git push --dry-run testrepo &&
git push --dry-run testrepo : &&
check_push_result testrepo $old_commit heads/master
'

Expand Down Expand Up @@ -1022,7 +1024,7 @@ test_expect_success 'push --porcelain --dry-run rejected' '

test_expect_success 'push --prune' '
mk_test testrepo heads/master heads/second heads/foo heads/bar &&
git push --prune testrepo &&
git push --prune testrepo : &&
check_push_result testrepo $the_commit heads/master &&
check_push_result testrepo $the_first_commit heads/second &&
! check_push_result testrepo $the_first_commit heads/foo heads/bar
Expand Down
2 changes: 1 addition & 1 deletion t/t5517-push-mirror.sh
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ test_expect_success 'remote.foo.mirror=no has no effect' '
git branch keep master &&
git push --mirror up &&
git branch -D keep &&
git push up
git push up :
) &&
(
cd mirror &&
Expand Down
12 changes: 6 additions & 6 deletions t/t5519-push-alternates.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ test_expect_success 'alice works and pushes' '
cd alice-work &&
echo more >file &&
git commit -a -m second &&
git push ../alice-pub
git push ../alice-pub :
)
'

Expand All @@ -57,7 +57,7 @@ test_expect_success 'bob fetches from alice, works and pushes' '
git pull ../alice-pub master &&
echo more bob >file &&
git commit -a -m third &&
git push ../bob-pub
git push ../bob-pub :
) &&
# Check that the second commit by Alice is not sent
Expand Down Expand Up @@ -86,7 +86,7 @@ test_expect_success 'alice works and pushes again' '
cd alice-work &&
echo more alice >file &&
git commit -a -m fourth &&
git push ../alice-pub
git push ../alice-pub :
)
'

Expand All @@ -99,7 +99,7 @@ test_expect_success 'bob works and pushes' '
cd bob-work &&
echo yet more bob >file &&
git commit -a -m fifth &&
git push ../bob-pub
git push ../bob-pub :
)
'

Expand All @@ -115,7 +115,7 @@ test_expect_success 'alice works and pushes yet again' '
git commit -a -m sixth.2 &&
echo more and more alice >>file &&
git commit -a -m sixth.3 &&
git push ../alice-pub
git push ../alice-pub :
)
'

Expand All @@ -136,7 +136,7 @@ test_expect_success 'bob works and pushes again' '
git hash-object -t commit -w commit &&
echo even more bob >file &&
git commit -a -m seventh &&
git push ../bob-pub
git push ../bob-pub :
)
'

Expand Down
1 change: 1 addition & 0 deletions t/t5531-deep-submodule-push.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ test_expect_success setup '
(
cd gar/bage &&
git init &&
git config push.default matching &&
>junk &&
git add junk &&
git commit -m "Initial junk"
Expand Down
1 change: 1 addition & 0 deletions t/t5550-http-fetch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ LIB_HTTPD_PORT=${LIB_HTTPD_PORT-'5550'}
start_httpd

test_expect_success 'setup repository' '
git config push.default matching &&
echo content1 >file &&
git add file &&
git commit -m one
Expand Down
1 change: 1 addition & 0 deletions t/t5551-http-fetch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ LIB_HTTPD_PORT=${LIB_HTTPD_PORT-'5551'}
start_httpd

test_expect_success 'setup repository' '
git config push.default matching &&
echo content >file &&
git add file &&
git commit -m one
Expand Down
1 change: 1 addition & 0 deletions t/t5570-git-daemon.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ LIB_GIT_DAEMON_PORT=${LIB_GIT_DAEMON_PORT-5570}
start_git_daemon

test_expect_success 'setup repository' '
git config push.default matching &&
echo content >file &&
git add file &&
git commit -m one
Expand Down
4 changes: 2 additions & 2 deletions t/t7406-submodule-update.sh
Original file line number Diff line number Diff line change
Expand Up @@ -596,14 +596,14 @@ test_expect_success 'submodule add places git-dir in superprojects git-dir recur
git log > ../../../expected
) &&
git commit -m "added subsubmodule" &&
git push
git push origin :
) &&
(cd .git/modules/deeper/submodule/modules/subsubmodule &&
git log > ../../../../../actual
) &&
git add deeper/submodule &&
git commit -m "update submodule" &&
git push &&
git push origin : &&
test_cmp actual expected
)
'
Expand Down
1 change: 1 addition & 0 deletions t/t9400-git-cvsserver-server.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export CVSROOT CVS_SERVER

rm -rf "$CVSWORK" "$SERVERDIR"
test_expect_success 'setup' '
git config push.default matching &&
echo >empty &&
git add empty &&
git commit -q -m "First Commit" &&
Expand Down
1 change: 1 addition & 0 deletions t/t9401-git-cvsserver-crlf.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export CVSROOT CVS_SERVER

rm -rf "$CVSWORK" "$SERVERDIR"
test_expect_success 'setup' '
git config push.default matching &&
echo "Simple text file" >textfile.c &&
echo "File with embedded NUL: Q <- there" | q_to_nul > binfile.bin &&
mkdir subdir &&
Expand Down

0 comments on commit 54a3c67

Please sign in to comment.