Skip to content

Commit

Permalink
Merge branch 'nh/empty-rebase'
Browse files Browse the repository at this point in the history
By Neil Horman
* nh/empty-rebase:
  git cherry-pick: do not dereference a potential NULL pointer
  • Loading branch information
Junio C Hamano committed May 7, 2012
2 parents fc1320b + 4b58006 commit 5543501
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions sequencer.c
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,17 @@ static int is_index_unchanged(void)
return error(_("Could not resolve HEAD commit\n"));

head_commit = lookup_commit(head_sha1);
if (!head_commit || parse_commit(head_commit))
return error(_("could not parse commit %s\n"),
sha1_to_hex(head_commit->object.sha1));

/*
* If head_commit is NULL, check_commit, called from
* lookup_commit, would have indicated that head_commit is not
* a commit object already. parse_commit() will return failure
* without further complaints in such a case. Otherwise, if
* the commit is invalid, parse_commit() will complain. So
* there is nothing for us to say here. Just return failure.
*/
if (parse_commit(head_commit))
return -1;

if (!active_cache_tree)
active_cache_tree = cache_tree();
Expand Down

0 comments on commit 5543501

Please sign in to comment.