Skip to content

Commit

Permalink
merge: notice local merging of tags and keep it unwrapped
Browse files Browse the repository at this point in the history
This also updates the autogenerated merge title message from "merge commit X"
to "merge tag X", and its effect can be seen in the changes to the test suite.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Nov 7, 2011
1 parent 7a2b128 commit 57b58db
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 8 deletions.
5 changes: 5 additions & 0 deletions builtin/merge.c
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,11 @@ static void merge_name(const char *remote, struct strbuf *msg)
sha1_to_hex(branch_head), remote);
goto cleanup;
}
if (!prefixcmp(found_ref, "refs/tags/")) {
strbuf_addf(msg, "%s\t\ttag '%s' of .\n",
sha1_to_hex(branch_head), remote);
goto cleanup;
}
if (!prefixcmp(found_ref, "refs/remotes/")) {
strbuf_addf(msg, "%s\t\tremote-tracking branch '%s' of .\n",
sha1_to_hex(branch_head), remote);
Expand Down
4 changes: 2 additions & 2 deletions t/t4202-log.sh
Original file line number Diff line number Diff line change
Expand Up @@ -346,11 +346,11 @@ test_expect_success 'set up more tangled history' '
'

cat > expect <<\EOF
* Merge commit 'reach'
* Merge tag 'reach'
|\
| \
| \
*-. \ Merge commit 'octopus-a'; commit 'octopus-b'
*-. \ Merge tags 'octopus-a' and 'octopus-b'
|\ \ \
* | | | seventh
| | * | octopus-b
Expand Down
6 changes: 3 additions & 3 deletions t/t7600-merge.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ printf '%s\n' '1 X' 2 3 4 '5 X' 6 7 8 '9 X' >result.1-5-9
>empty

create_merge_msgs () {
echo "Merge commit 'c2'" >msg.1-5 &&
echo "Merge commit 'c2'; commit 'c3'" >msg.1-5-9 &&
echo "Merge tag 'c2'" >msg.1-5 &&
echo "Merge tags 'c2' and 'c3'" >msg.1-5-9 &&
{
echo "Squashed commit of the following:" &&
echo &&
Expand All @@ -57,7 +57,7 @@ create_merge_msgs () {
} >squash.1-5-9 &&
echo >msg.nolog &&
{
echo "* commit 'c3':" &&
echo "* tag 'c3':" &&
echo " commit 3" &&
echo
} >msg.log
Expand Down
2 changes: 1 addition & 1 deletion t/t7604-merge-custom-message.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ create_merge_msgs() {

cp exp.subject exp.log &&
echo >>exp.log "" &&
echo >>exp.log "* commit 'c2':" &&
echo >>exp.log "* tag 'c2':" &&
echo >>exp.log " c2"
}

Expand Down
4 changes: 2 additions & 2 deletions t/t7608-merge-messages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test_expect_success 'merge tag' '
git checkout master &&
test_commit master-3 &&
git merge tag-1 &&
check_oneline "Merge commit Qtag-1Q"
check_oneline "Merge tag Qtag-1Q"
'

test_expect_success 'ambiguous tag' '
Expand All @@ -44,7 +44,7 @@ test_expect_success 'ambiguous tag' '
git checkout master &&
test_commit master-4 &&
git merge ambiguous &&
check_oneline "Merge commit QambiguousQ"
check_oneline "Merge tag QambiguousQ"
'

test_expect_success 'remote-tracking branch' '
Expand Down

0 comments on commit 57b58db

Please sign in to comment.