Skip to content

Commit

Permalink
Merge branch 'jc/maint-rebase-rewrite-last-skip' into maint
Browse files Browse the repository at this point in the history
* jc/maint-rebase-rewrite-last-skip:
  rebase --skip: correctly wrap-up when skipping the last patch
  • Loading branch information
Junio C Hamano committed Dec 28, 2010
2 parents 2f73969 + ef88ad2 commit 58c58c8
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 8 deletions.
7 changes: 0 additions & 7 deletions git-am.sh
Original file line number Diff line number Diff line change
Expand Up @@ -577,13 +577,6 @@ then
resume=
fi

if test "$this" -gt "$last"
then
say Nothing to do.
rm -fr "$dotest"
exit
fi

while test "$this" -le "$last"
do
msgnum=`printf "%0${prec}d" $this`
Expand Down
18 changes: 17 additions & 1 deletion t/t5407-post-rewrite-hook.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ test_expect_success 'setup' '
test_commit A foo A &&
test_commit B foo B &&
test_commit C foo C &&
test_commit D foo D
test_commit D foo D &&
git checkout A^0 &&
test_commit E bar E &&
test_commit F foo F &&
git checkout master
'

mkdir .git/hooks
Expand Down Expand Up @@ -79,6 +83,18 @@ EOF
verify_hook_input
'

test_expect_success 'git rebase --skip the last one' '
git reset --hard F &&
clear_hook_input &&
test_must_fail git rebase --onto D A &&
git rebase --skip &&
echo rebase >expected.args &&
cat >expected.data <<EOF &&
$(git rev-parse E) $(git rev-parse HEAD)
EOF
verify_hook_input
'

test_expect_success 'git rebase -m' '
git reset --hard D &&
clear_hook_input &&
Expand Down

0 comments on commit 58c58c8

Please sign in to comment.