Skip to content

Commit

Permalink
xdiff/xprepare: use the XDF_DIFF_ALG() macro to access flag bits
Browse files Browse the repository at this point in the history
Commit 307ab20 ("xdiff: PATIENCE/HISTOGRAM are not independent option
bits", 19-02-2012) introduced the XDF_DIFF_ALG() macro to access the
flag bits used to represent the diff algorithm requested. In addition,
code which had used explicit manipulation of the flag bits was changed
to use the macros.

However, one example of direct manipulation remains. Update this code to
use the XDF_DIFF_ALG() macro.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ramsay Jones authored and Junio C Hamano committed Mar 4, 2016
1 parent a2558fb commit 5cd6978
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xdiff/xprepare.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ int xdl_prepare_env(mmfile_t *mf1, mmfile_t *mf2, xpparam_t const *xpp,
return -1;
}

if (!(xpp->flags & XDF_HISTOGRAM_DIFF))
if (XDF_DIFF_ALG(xpp->flags) != XDF_HISTOGRAM_DIFF)
xdl_free_classifier(&cf);

return 0;
Expand Down

0 comments on commit 5cd6978

Please sign in to comment.