Skip to content

Commit

Permalink
revert: refactor commit code into a new run_git_commit() function
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Christian Couder authored and Junio C Hamano committed Jul 16, 2010
1 parent 7b53b92 commit 5df1645
Showing 1 changed file with 27 additions and 25 deletions.
52 changes: 27 additions & 25 deletions builtin/revert.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,32 @@ static int do_recursive_merge(struct commit *base, struct commit *next,
return !clean;
}

/*
* If we are cherry-pick, and if the merge did not result in
* hand-editing, we will hit this commit and inherit the original
* author date and name.
* If we are revert, or if our cherry-pick results in a hand merge,
* we had better say that the current user is responsible for that.
*/
static int run_git_commit(const char *defmsg)
{
/* 6 is max possible length of our args array including NULL */
const char *args[6];
int i = 0;

args[i++] = "commit";
args[i++] = "-n";
if (signoff)
args[i++] = "-s";
if (!edit) {
args[i++] = "-F";
args[i++] = defmsg;
}
args[i] = NULL;

return run_command_v_opt(args, RUN_GIT_CMD);
}

static int do_pick_commit(void)
{
unsigned char head[20];
Expand Down Expand Up @@ -501,33 +527,9 @@ static int do_pick_commit(void)
if (res)
return 1;

/*
*
* If we are cherry-pick, and if the merge did not result in
* hand-editing, we will hit this commit and inherit the original
* author date and name.
* If we are revert, or if our cherry-pick results in a hand merge,
* we had better say that the current user is responsible for that.
*/

if (!no_commit) {
/* 6 is max possible length of our args array including NULL */
const char *args[6];
int res;
int i = 0;

args[i++] = "commit";
args[i++] = "-n";
if (signoff)
args[i++] = "-s";
if (!edit) {
args[i++] = "-F";
args[i++] = defmsg;
}
args[i] = NULL;
res = run_command_v_opt(args, RUN_GIT_CMD);
res = run_git_commit(defmsg);
free(defmsg);

return res;
}

Expand Down

0 comments on commit 5df1645

Please sign in to comment.