Skip to content

Commit

Permalink
Merge branch 'va/p4'
Browse files Browse the repository at this point in the history
* va/p4:
  git-p4: Add copy detection support
  git-p4: Improve rename detection support
  • Loading branch information
Junio C Hamano committed Feb 28, 2011
2 parents 8d3a362 + 4fddb41 commit 5e3d39b
Showing 1 changed file with 31 additions and 4 deletions.
35 changes: 31 additions & 4 deletions contrib/fast-import/git-p4
Original file line number Diff line number Diff line change
Expand Up @@ -543,13 +543,13 @@ class P4Submit(Command):
self.options = [
optparse.make_option("--verbose", dest="verbose", action="store_true"),
optparse.make_option("--origin", dest="origin"),
optparse.make_option("-M", dest="detectRename", action="store_true"),
optparse.make_option("-M", dest="detectRenames", action="store_true"),
]
self.description = "Submit changes from git to the perforce depot."
self.usage += " [name of git branch to submit into perforce depot]"
self.interactive = True
self.origin = ""
self.detectRename = False
self.detectRenames = False
self.verbose = False
self.isWindows = (platform.system() == "Windows")

Expand Down Expand Up @@ -613,7 +613,22 @@ class P4Submit(Command):

def applyCommit(self, id):
print "Applying %s" % (read_pipe("git log --max-count=1 --pretty=oneline %s" % id))
diffOpts = ("", "-M")[self.detectRename]

if not self.detectRenames:
# If not explicitly set check the config variable
self.detectRenames = gitConfig("git-p4.detectRenames").lower() == "true"

if self.detectRenames:
diffOpts = "-M"
else:
diffOpts = ""

if gitConfig("git-p4.detectCopies").lower() == "true":
diffOpts += " -C"

if gitConfig("git-p4.detectCopiesHarder").lower() == "true":
diffOpts += " --find-copies-harder"

diff = read_pipe_lines("git diff-tree -r %s \"%s^\" \"%s\"" % (diffOpts, id, id))
filesToAdd = set()
filesToDelete = set()
Expand All @@ -637,11 +652,23 @@ class P4Submit(Command):
filesToDelete.add(path)
if path in filesToAdd:
filesToAdd.remove(path)
elif modifier == "C":
src, dest = diff['src'], diff['dst']
p4_system("integrate -Dt \"%s\" \"%s\"" % (src, dest))
if diff['src_sha1'] != diff['dst_sha1']:
p4_system("edit \"%s\"" % (dest))
if isModeExecChanged(diff['src_mode'], diff['dst_mode']):
p4_system("edit \"%s\"" % (dest))
filesToChangeExecBit[dest] = diff['dst_mode']
os.unlink(dest)
editedFiles.add(dest)
elif modifier == "R":
src, dest = diff['src'], diff['dst']
p4_system("integrate -Dt \"%s\" \"%s\"" % (src, dest))
p4_system("edit \"%s\"" % (dest))
if diff['src_sha1'] != diff['dst_sha1']:
p4_system("edit \"%s\"" % (dest))
if isModeExecChanged(diff['src_mode'], diff['dst_mode']):
p4_system("edit \"%s\"" % (dest))
filesToChangeExecBit[dest] = diff['dst_mode']
os.unlink(dest)
editedFiles.add(dest)
Expand Down

0 comments on commit 5e3d39b

Please sign in to comment.