Skip to content

Commit

Permalink
[PATCH] Fix for --merge-order, --max-age interaction issue
Browse files Browse the repository at this point in the history
This patch fixes a problem reported by Paul Mackerras regarding the interaction
of the --merge-order and --max-age switches of git-rev-list.

This patch applies to the current Linus HEAD. A cleaner fix for the same problem
in my current HEAD will follow later.

With this change, --merge-order produces the same result as no --merge-order
on the linux-2.6 git repository, to wit:

$> git-rev-list --max-age=1116330140 bcfff0b471a60df350338bcd727fc9b8a6aa54b2 | wc -l
655
$> git-rev-list --merge-order --max-age=1116330140 bcfff0b471a60df350338bcd727fc9b8a6aa54b2 | wc -l
655

Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jon Seymour authored and Linus Torvalds committed Jun 20, 2005
1 parent 51b1e17 commit 5e749e2
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions rev-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ static int max_count = -1;
static enum cmit_fmt commit_format = CMIT_FMT_RAW;
static int merge_order = 0;
static int show_breaks = 0;
static int stop_traversal = 0;

static void show_commit(struct commit *commit)
{
Expand Down Expand Up @@ -57,12 +58,20 @@ static void show_commit(struct commit *commit)

static int filter_commit(struct commit * commit)
{
if (merge_order && stop_traversal && commit->object.flags & BOUNDARY)
return STOP;
if (commit->object.flags & (UNINTERESTING|SHOWN))
return CONTINUE;
if (min_age != -1 && (commit->date > min_age))
return CONTINUE;
if (max_age != -1 && (commit->date < max_age))
return STOP;
if (max_age != -1 && (commit->date < max_age)) {
if (!merge_order)
return STOP;
else {
stop_traversal = 1;
return CONTINUE;
}
}
if (max_count != -1 && !max_count--)
return STOP;
return DO;
Expand Down

0 comments on commit 5e749e2

Please sign in to comment.