Skip to content

Commit

Permalink
get_remote_group(): eliminate superfluous call to strcspn()
Browse files Browse the repository at this point in the history
There is no need to call it if value is the empty string. This also
eliminates code duplication.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Michael Haggerty authored and Junio C Hamano committed Jul 28, 2015
1 parent e286542 commit 5f65499
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions builtin/fetch.c
Original file line number Diff line number Diff line change
Expand Up @@ -976,13 +976,13 @@ static int get_remote_group(const char *key, const char *value, void *priv)
if (starts_with(key, "remotes.") &&
!strcmp(key + 8, g->name)) {
/* split list by white space */
size_t wordlen = strcspn(value, " \t\n");
while (*value) {
size_t wordlen = strcspn(value, " \t\n");

if (wordlen >= 1)
string_list_append(g->list,
xstrndup(value, wordlen));
value += wordlen + (value[wordlen] != '\0');
wordlen = strcspn(value, " \t\n");
}
}

Expand Down

0 comments on commit 5f65499

Please sign in to comment.