Skip to content

Commit

Permalink
Merge branch 'jh/push-default-upstream-configname' into maint
Browse files Browse the repository at this point in the history
* jh/push-default-upstream-configname:
  push.default: Rename 'tracking' to 'upstream'
  • Loading branch information
Junio C Hamano committed Mar 16, 2011
2 parents 7633a5a + 53c4031 commit 61a6f1f
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 9 deletions.
3 changes: 2 additions & 1 deletion Documentation/config.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1582,7 +1582,8 @@ push.default::
* `matching` - push all matching branches.
All branches having the same name in both ends are considered to be
matching. This is the default.
* `tracking` - push the current branch to its upstream branch.
* `upstream` - push the current branch to its upstream branch.
* `tracking` - deprecated synonym for `upstream`.
* `current` - push the current branch to a branch of the same name.

rebase.stat::
Expand Down
10 changes: 5 additions & 5 deletions builtin/push.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,17 +64,17 @@ static void set_refspecs(const char **refs, int nr)
}
}

static void setup_push_tracking(void)
static void setup_push_upstream(void)
{
struct strbuf refspec = STRBUF_INIT;
struct branch *branch = branch_get(NULL);
if (!branch)
die("You are not currently on a branch.");
if (!branch->merge_nr || !branch->merge)
die("The current branch %s is not tracking anything.",
die("The current branch %s has no upstream branch.",
branch->name);
if (branch->merge_nr != 1)
die("The current branch %s is tracking multiple branches, "
die("The current branch %s has multiple upstream branches, "
"refusing to push.", branch->name);
strbuf_addf(&refspec, "%s:%s", branch->name, branch->merge[0]->src);
add_refspec(refspec.buf);
Expand All @@ -88,8 +88,8 @@ static void setup_default_push_refspecs(void)
add_refspec(":");
break;

case PUSH_DEFAULT_TRACKING:
setup_push_tracking();
case PUSH_DEFAULT_UPSTREAM:
setup_push_upstream();
break;

case PUSH_DEFAULT_CURRENT:
Expand Down
2 changes: 1 addition & 1 deletion cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ enum rebase_setup_type {
enum push_default_type {
PUSH_DEFAULT_NOTHING = 0,
PUSH_DEFAULT_MATCHING,
PUSH_DEFAULT_TRACKING,
PUSH_DEFAULT_UPSTREAM,
PUSH_DEFAULT_CURRENT
};

Expand Down
6 changes: 4 additions & 2 deletions config.c
Original file line number Diff line number Diff line change
Expand Up @@ -729,8 +729,10 @@ static int git_default_push_config(const char *var, const char *value)
push_default = PUSH_DEFAULT_NOTHING;
else if (!strcmp(value, "matching"))
push_default = PUSH_DEFAULT_MATCHING;
else if (!strcmp(value, "tracking"))
push_default = PUSH_DEFAULT_TRACKING;
else if (!strcmp(value, "upstream"))
push_default = PUSH_DEFAULT_UPSTREAM;
else if (!strcmp(value, "tracking")) /* deprecated */
push_default = PUSH_DEFAULT_UPSTREAM;
else if (!strcmp(value, "current"))
push_default = PUSH_DEFAULT_CURRENT;
else {
Expand Down

0 comments on commit 61a6f1f

Please sign in to comment.