Skip to content

Commit

Permalink
read-cache: relocate and unexport commit_locked_index()
Browse files Browse the repository at this point in the history
This function is now only used by write_locked_index(). Move it to
read-cache.c (because read-cache.c will need to be aware of
alternate_index_output later) and unexport it.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Nguyễn Thái Ngọc Duy authored and Junio C Hamano committed Jun 13, 2014
1 parent 03b8664 commit 626f35c
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 21 deletions.
1 change: 0 additions & 1 deletion cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,6 @@ extern int commit_lock_file(struct lock_file *);
extern void update_index_if_able(struct index_state *, struct lock_file *);

extern int hold_locked_index(struct lock_file *, int);
extern int commit_locked_index(struct lock_file *);
extern void set_alternate_index_output(const char *);
extern int close_lock_file(struct lock_file *);
extern void rollback_lock_file(struct lock_file *);
Expand Down
20 changes: 0 additions & 20 deletions lockfile.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "sigchain.h"

static struct lock_file *lock_file_list;
static const char *alternate_index_output;

static void remove_lock_file(void)
{
Expand Down Expand Up @@ -252,25 +251,6 @@ int hold_locked_index(struct lock_file *lk, int die_on_error)
: 0);
}

void set_alternate_index_output(const char *name)
{
alternate_index_output = name;
}

int commit_locked_index(struct lock_file *lk)
{
if (alternate_index_output) {
if (lk->fd >= 0 && close_lock_file(lk))
return -1;
if (rename(lk->filename, alternate_index_output))
return -1;
lk->filename[0] = 0;
return 0;
}
else
return commit_lock_file(lk);
}

void rollback_lock_file(struct lock_file *lk)
{
if (lk->filename[0]) {
Expand Down
20 changes: 20 additions & 0 deletions read-cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ static struct cache_entry *refresh_cache_entry(struct cache_entry *ce,
#define CACHE_EXT_RESOLVE_UNDO 0x52455543 /* "REUC" */

struct index_state the_index;
static const char *alternate_index_output;

static void set_index_entry(struct index_state *istate, int nr, struct cache_entry *ce)
{
Expand Down Expand Up @@ -1875,6 +1876,25 @@ static int do_write_index(struct index_state *istate, int newfd)
return 0;
}

void set_alternate_index_output(const char *name)
{
alternate_index_output = name;
}

static int commit_locked_index(struct lock_file *lk)
{
if (alternate_index_output) {
if (lk->fd >= 0 && close_lock_file(lk))
return -1;
if (rename(lk->filename, alternate_index_output))
return -1;
lk->filename[0] = 0;
return 0;
} else {
return commit_lock_file(lk);
}
}

static int do_write_locked_index(struct index_state *istate, struct lock_file *lock,
unsigned flags)
{
Expand Down

0 comments on commit 626f35c

Please sign in to comment.