Skip to content

Commit

Permalink
gitweb: Always call parse_date with timezone parameter
Browse files Browse the repository at this point in the history
Timezone is required to correctly set local time, which would be needed
for future 'localtime' feature.

While at it, remove unnecessary call to the function from git_log_body,
as its return value is not used anywhere.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jakub Narebski authored and Junio C Hamano committed Mar 20, 2011
1 parent 958bf6b commit 6368d9f
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions gitweb/gitweb.perl
Original file line number Diff line number Diff line change
Expand Up @@ -4906,7 +4906,6 @@ sub git_log_body {
next if !%co;
my $commit = $co{'id'};
my $ref = format_ref_marker($refs, $commit);
my %ad = parse_date($co{'author_epoch'});
git_print_header_div('commit',
"<span class=\"age\">$co{'age_string'}</span>" .
esc_html($co{'title'}) . $ref,
Expand Down Expand Up @@ -7064,7 +7063,7 @@ sub git_feed {
if (defined($commitlist[0])) {
%latest_commit = %{$commitlist[0]};
my $latest_epoch = $latest_commit{'committer_epoch'};
%latest_date = parse_date($latest_epoch);
%latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
my $if_modified = $cgi->http('IF_MODIFIED_SINCE');
if (defined $if_modified) {
my $since;
Expand Down Expand Up @@ -7195,7 +7194,7 @@ sub git_feed {
if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) {
last;
}
my %cd = parse_date($co{'author_epoch'});
my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'});

# get list of changed files
open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
Expand Down

0 comments on commit 6368d9f

Please sign in to comment.