Skip to content

Commit

Permalink
imap-send.c: fold struct store into struct imap_store
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Michael Haggerty authored and Junio C Hamano committed Jan 15, 2013
1 parent 9a08cbb commit 636fd66
Showing 1 changed file with 7 additions and 11 deletions.
18 changes: 7 additions & 11 deletions imap-send.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@ typedef void *SSL;
#include <openssl/hmac.h>
#endif

struct store {
/* currently open mailbox */
const char *name; /* foreign! maybe preset? */
int uidvalidity;
};

static const char imap_send_usage[] = "git imap-send < <mbox>";

#undef DRV_OK
Expand Down Expand Up @@ -123,7 +117,9 @@ struct imap {
};

struct imap_store {
struct store gen;
/* currently open mailbox */
const char *name; /* foreign! maybe preset? */
int uidvalidity;
struct imap *imap;
const char *prefix;
};
Expand Down Expand Up @@ -618,7 +614,7 @@ static int parse_response_code(struct imap_store *ctx, struct imap_cmd_cb *cb,
*p++ = 0;
arg = next_arg(&s);
if (!strcmp("UIDVALIDITY", arg)) {
if (!(arg = next_arg(&s)) || !(ctx->gen.uidvalidity = atoi(arg))) {
if (!(arg = next_arg(&s)) || !(ctx->uidvalidity = atoi(arg))) {
fprintf(stderr, "IMAP error: malformed UIDVALIDITY status\n");
return RESP_BAD;
}
Expand All @@ -636,7 +632,7 @@ static int parse_response_code(struct imap_store *ctx, struct imap_cmd_cb *cb,
for (; isspace((unsigned char)*p); p++);
fprintf(stderr, "*** IMAP ALERT *** %s\n", p);
} else if (cb && cb->ctx && !strcmp("APPENDUID", arg)) {
if (!(arg = next_arg(&s)) || !(ctx->gen.uidvalidity = atoi(arg)) ||
if (!(arg = next_arg(&s)) || !(ctx->uidvalidity = atoi(arg)) ||
!(arg = next_arg(&s)) || !(*(int *)cb->ctx = atoi(arg))) {
fprintf(stderr, "IMAP error: malformed APPENDUID status\n");
return RESP_BAD;
Expand Down Expand Up @@ -1150,7 +1146,7 @@ static int imap_store_msg(struct imap_store *ctx, struct strbuf *msg)
cb.dlen = msg->len;
cb.data = strbuf_detach(msg, NULL);

box = ctx->gen.name;
box = ctx->name;
prefix = !strcmp(box, "INBOX") ? "" : ctx->prefix;
cb.create = 0;
ret = imap_exec_m(ctx, &cb, "APPEND \"%s%s\" ", prefix, box);
Expand Down Expand Up @@ -1362,7 +1358,7 @@ int main(int argc, char **argv)
}

fprintf(stderr, "sending %d message%s\n", total, (total != 1) ? "s" : "");
ctx->gen.name = imap_folder;
ctx->name = imap_folder;
while (1) {
unsigned percent = n * 100 / total;

Expand Down

0 comments on commit 636fd66

Please sign in to comment.