Skip to content

Commit

Permalink
gitweb: Do not use absolute font sizes
Browse files Browse the repository at this point in the history
Avoid specifying font sizes in pixels, since that is just pure evil.
Pointed out by Chris Riddoch.

Note that this is pretty much just a proposal; I didn't test if everything
fits perfectly right, but things seem to be pretty much okay. repo.or.cz
uses it now as a test drive - if you find any visual quirks, please point
them out, with a patch if possible since I'm total CSS noob and debugging
CSS is an extremely painful experience for me.

Note that this patch actually does change visual look of gitweb in Firefox
with my resolution and default settings - everything is bigger and I can't
explain the joy of actually seeing gitweb text that is in _readable_ size;
also, my horizontal screen real estate feels better used now. But judging
from the look of most modern webpages on the 'net, most people prefer
reading the web with strained eyes and/or a magnifying glass (I wonder what
species of scientists should look into this mystifying phenomenon) - so,
please tell us what you think.

Maybe we might want to get rid of absolute sizes other than font sizes in
the CSS file too in the long term.

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Petr Baudis authored and Junio C Hamano committed May 10, 2007
1 parent 35c49ee commit 63fcbe0
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions gitweb/gitweb.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
body {
font-family: sans-serif;
font-size: 12px;
border: solid #d9d8d1;
border-width: 1px;
margin: 10px;
Expand Down Expand Up @@ -31,7 +30,7 @@ img.logo {
div.page_header {
height: 25px;
padding: 8px;
font-size: 18px;
font-size: 150%;
font-weight: bold;
background-color: #d9d8d1;
}
Expand Down Expand Up @@ -113,7 +112,7 @@ span.signoff {

div.log_link {
padding: 0px 8px;
font-size: 10px;
font-size: 70%;
font-family: sans-serif;
font-style: normal;
position: relative;
Expand Down Expand Up @@ -204,13 +203,13 @@ table.blame {

table.blame td {
padding: 0px 5px;
font-size: 12px;
font-size: 100%;
vertical-align: top;
}

th {
padding: 2px 5px;
font-size: 12px;
font-size: 100%;
text-align: left;
}

Expand All @@ -232,14 +231,14 @@ tr.dark:hover {

td {
padding: 2px 5px;
font-size: 12px;
font-size: 100%;
vertical-align: top;
}

td.link, td.selflink {
padding: 2px 5px;
font-family: sans-serif;
font-size: 10px;
font-size: 70%;
}

td.selflink {
Expand Down Expand Up @@ -416,7 +415,7 @@ div.index_include {
}

div.search {
font-size: 12px;
font-size: 100%;
font-weight: normal;
margin: 4px 8px;
position: absolute;
Expand Down Expand Up @@ -444,7 +443,7 @@ a.rss_logo {
background-color: #ff6600;
font-weight: bold;
font-family: sans-serif;
font-size: 10px;
font-size: 70%;
text-align: center;
text-decoration: none;
}
Expand All @@ -455,7 +454,7 @@ a.rss_logo:hover {

span.refs span {
padding: 0px 4px;
font-size: 10px;
font-size: 70%;
font-weight: normal;
border: 1px solid;
background-color: #ffaaff;
Expand Down

0 comments on commit 63fcbe0

Please sign in to comment.