Skip to content

Commit

Permalink
Git.pm: better error message
Browse files Browse the repository at this point in the history
Provide the bad directory name alongside with $!

Note: $! is set if there is "No such file or directory",
but isn't set if the file exists but is not a directory.

Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Philippe Bruhat (BooK) authored and Junio C Hamano committed Jun 18, 2010
1 parent 74e42ce commit 64abcc4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions perl/Git.pm
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ sub repository {
}

if (defined $opts{Directory}) {
-d $opts{Directory} or throw Error::Simple("Directory not found: $!");
-d $opts{Directory} or throw Error::Simple("Directory not found: $opts{Directory} $!");

my $search = Git->repository(WorkingCopy => $opts{Directory});
my $dir;
Expand Down Expand Up @@ -545,7 +545,7 @@ sub wc_chdir {
or throw Error::Simple("bare repository");

-d $self->wc_path().'/'.$subdir
or throw Error::Simple("subdir not found: $!");
or throw Error::Simple("subdir not found: $subdir $!");
# Of course we will not "hold" the subdirectory so anyone
# can delete it now and we will never know. But at least we tried.

Expand Down

0 comments on commit 64abcc4

Please sign in to comment.