Skip to content

Commit

Permalink
request-pull: really really disable pager
Browse files Browse the repository at this point in the history
Earlier 476cc72 (request-pull: really disable pager, 2009-06-30)
tried to use the correct environment variable to disable paging
from multiple calls to "git log" and friends, but there was one
extra call to "git log" that was not covered by the trick.

Move the setting and exporting of GIT_PAGER much earlier in the
script to cover everybody.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Michal Marek authored and Junio C Hamano committed Jul 1, 2009
1 parent d4c9856 commit 653a31c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions git-request-pull.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ OPTIONS_SPEC=
. git-sh-setup
. git-parse-remote

GIT_PAGER=
export GIT_PAGER

base=$1
url=$2
head=${3-HEAD}
Expand All @@ -34,16 +37,14 @@ branch=$(git ls-remote "$url" \
}")
if [ -z "$branch" ]; then
echo "warn: No branch of $url is at:" >&2
git log --max-count=1 --pretty='format:warn: %h: %s' $headrev >&2
git log --max-count=1 --pretty='tformat:warn: %h: %s' $headrev >&2
echo "warn: Are you sure you pushed $head there?" >&2
echo >&2
echo >&2
branch=..BRANCH.NOT.VERIFIED..
status=1
fi

GIT_PAGER=
export GIT_PAGER
echo "The following changes since commit $baserev:"
git shortlog --max-count=1 $baserev | sed -e 's/^\(.\)/ \1/'

Expand Down

0 comments on commit 653a31c

Please sign in to comment.