Skip to content

Commit

Permalink
transport-helper: barf when user tries old:new
Browse files Browse the repository at this point in the history
Otherwise with certain remote helpers (the ones that support 'export'),
the users will be pushing to the wrong branch:

  git push topic:master

Will push the topic branch, as if the user typed:

  git push topic

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Felipe Contreras authored and Junio C Hamano committed May 21, 2013
1 parent 9134a46 commit 67c9c78
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions transport-helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -813,9 +813,11 @@ static int push_refs_with_export(struct transport *transport,
die("remote-helpers do not support ref deletion");
}

if (ref->peer_ref)
if (ref->peer_ref) {
if (strcmp(ref->peer_ref->name, ref->name))
die("remote-helpers do not support old:new syntax");
string_list_append(&revlist_args, ref->peer_ref->name);

}
}

if (get_exporter(transport, &exporter, &revlist_args))
Expand Down

0 comments on commit 67c9c78

Please sign in to comment.