Skip to content

Commit

Permalink
rebase: error out for NO_PYTHON if they use recursive merge
Browse files Browse the repository at this point in the history
recursive merge relies on Python, and we can't perform
rename-aware merges without the recursive merge.  So bail out
before trying it.

The test won't work w/o recursive merge, either, so skip that,
too.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Eric Wong authored and Junio C Hamano committed Jun 21, 2006
1 parent c3fb0e3 commit 693c15d
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
9 changes: 9 additions & 0 deletions git-rebase.sh
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,15 @@ then
exit $?
fi

if test "@@NO_PYTHON@@" && test "$strategy" = "recursive"
then
die 'The recursive merge strategy currently relies on Python,
which this installation of git was not configured with. Please consider
a different merge strategy (e.g. octopus, resolve, stupid, ours)
or install Python and git with Python support.'

fi

# start doing a rebase with git-merge
# this is rename-aware if the recursive (default) strategy is used

Expand Down
6 changes: 6 additions & 0 deletions t/t3402-rebase-merge.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ test_description='git rebase --merge test'

. ./test-lib.sh

if test "$no_python"; then
echo "Skipping: no python => no recursive merge"
test_done
exit 0
fi

T="A quick brown fox
jumps over the lazy dog."
for i in 1 2 3 4 5 6 7 8 9 10
Expand Down

0 comments on commit 693c15d

Please sign in to comment.