Skip to content

Commit

Permalink
t/t7811-grep-open.sh: ensure fake "less" is made executable
Browse files Browse the repository at this point in the history
The fake "less" script was not being made executable.  This can cause the
tests that follow to fail.  This failure is not apparent on platforms which
have DEFAULT_PAGER set to the string "less", since lib-pager.sh will have
set the $less variable to "less" and the SIMPLEPAGER prerequisite will have
been set, and so the "less" script will have already been created properly
and made executable in test 2 'git grep -O'.  On platforms which set
DEFAULT_PAGER to something like "more", no such script will have been
previously created, and tests 7 and 8 will fail.

So, add a call to chmod to make the fake "less" script executable.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Brandon Casey authored and Junio C Hamano committed Jun 21, 2010
1 parent 832ac79 commit 6a1b3fc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion t/t7811-grep-open.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,11 @@ test_expect_success 'git grep -O --no-index' '
'

test_expect_success 'setup: fake "less"' '
cat >less <<-\EOF
cat >less <<-\EOF &&
#!/bin/sh
printf "%s\n" "$@" >actual
EOF
chmod +x less
'

test_expect_success 'git grep -O jumps to line in less' '
Expand Down

0 comments on commit 6a1b3fc

Please sign in to comment.