Skip to content

Commit

Permalink
Fix git-format-patch -s
Browse files Browse the repository at this point in the history
When git-format-patch was converted to a builtin an appropriate call
to setup_ident was missed and thus git-format-patch -s fails because
it doesn't look up anything in the password file.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Eric W. Biederman authored and Junio C Hamano committed Jun 18, 2006
1 parent cb11574 commit 6c4cca1
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions builtin-log.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,11 @@ int cmd_format_patch(int argc, const char **argv, char **envp)
}
else if (!strcmp(argv[i], "--signoff") ||
!strcmp(argv[i], "-s")) {
const char *committer = git_committer_info(1);
const char *endpos = strchr(committer, '>');
const char *committer;
const char *endpos;
setup_ident();
committer = git_committer_info(1);
endpos = strchr(committer, '>');
if (!endpos)
die("bogos committer info %s\n", committer);
add_signoff = xmalloc(endpos - committer + 2);
Expand Down

0 comments on commit 6c4cca1

Please sign in to comment.