Skip to content

Commit

Permalink
gitk: Make "git describe" output clickable, too
Browse files Browse the repository at this point in the history
Automake's contribution guidelines suggest using "git describe" output
in commit logs to reference previous commits.  By contrast, in
coreutils, I had acquired the habit of using a bare SHA1 prefix (8 hex
digits), since gitk creates clickable links for that, and not for "git
describe" output.

I prefer the readability of the full "git describe" output, yet want
to retain the gitk links, so this renders as clickable not just
SHA1-like strings, but also an SHA1-like string that is prefixed by
"-g".

Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Jim Meyering authored and Paul Mackerras committed Mar 18, 2012
1 parent 65bb0bd commit 6c9e2d1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion gitk
Original file line number Diff line number Diff line change
Expand Up @@ -6734,7 +6734,7 @@ proc appendwithlinks {text tags} {

set start [$ctext index "end - 1c"]
$ctext insert end $text $tags
set links [regexp -indices -all -inline {\m[0-9a-f]{6,40}\M} $text]
set links [regexp -indices -all -inline {(?:\m|-g)[0-9a-f]{6,40}\M} $text]
foreach l $links {
set s [lindex $l 0]
set e [lindex $l 1]
Expand All @@ -6750,6 +6750,10 @@ proc appendwithlinks {text tags} {
proc setlink {id lk} {
global curview ctext pendinglinks

if {[string range $id 0 1] eq "-g"} {
set id [string range $id 2 end]
}

set known 0
if {[string length $id] < 40} {
set matches [longid $id]
Expand Down

0 comments on commit 6c9e2d1

Please sign in to comment.