Skip to content

Commit

Permalink
gitk: Fix bug in accessing undefined "notflag" variable
Browse files Browse the repository at this point in the history
As pointed out by Johannes Sixt and Alexander Gavrilov, commit
2958228 ("gitk: Fix switch statement
in parseviewargs") exposed a latent bug in that $notflag was never
initialized.  Since it isn't used either, this removes it entirely.

Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Paul Mackerras committed Dec 1, 2008
1 parent 8b39e04 commit 6e7e87c
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions gitk
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,7 @@ proc parseviewargs {n arglist} {
set nextisval 1
lappend glflags $arg
}
"--not" {
set notflag [expr {!$notflag}]
lappend revargs $arg
}
"--all" {
"--not" - "--all" {
lappend revargs $arg
}
"--merge" {
Expand Down

0 comments on commit 6e7e87c

Please sign in to comment.