Skip to content

Commit

Permalink
filter-branch: make report-progress more readable
Browse files Browse the repository at this point in the history
The name of some variables that are used very locally in this
function were overly long; they were making the lines harder to read
and the longer names didn't add much more information.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Sep 21, 2015
1 parent 6a9d16a commit 71400d9
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions git-filter-branch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -280,18 +280,20 @@ report_progress ()
if test -n "$progress" &&
test $git_filter_branch__commit_count -gt $next_sample_at
then
now_timestamp=$(date +%s)
elapsed_seconds=$(($now_timestamp - $start_timestamp))
remaining_second=$(( ($commits - $git_filter_branch__commit_count) * $elapsed_seconds / $git_filter_branch__commit_count ))
if test $elapsed_seconds -gt 0
count=$git_filter_branch__commit_count

now=$(date +%s)
elapsed=$(($now - $start_timestamp))
remaining=$(( ($commits - $count) * $elapsed / $count ))
if test $elapsed -gt 0
then
next_sample_at=$(( ($elapsed_seconds + 1) * $git_filter_branch__commit_count / $elapsed_seconds ))
next_sample_at=$(( ($elapsed + 1) * $count / $elapsed ))
else
next_sample_at=$(($next_sample_at + 1))
fi
progress=" ($elapsed_seconds seconds passed, remaining $remaining_second predicted)"
progress=" ($elapsed seconds passed, remaining $remaining predicted)"
fi
printf "\rRewrite $commit ($git_filter_branch__commit_count/$commits)$progress "
printf "\rRewrite $commit ($count/$commits)$progress "
}

git_filter_branch__commit_count=0
Expand Down

0 comments on commit 71400d9

Please sign in to comment.