Skip to content

Commit

Permalink
gitk: Fix bug causing undefined variable error when cherry-picking
Browse files Browse the repository at this point in the history
When "Show nearby tags" is turned off and the user did a cherry-pick,
we were trying to access variables relating to the descendent/ancestor
tag & head computations in addnewchild though they hadn't been set.
This makes sure we don't do that.  Reported by Johannes Sixt.

Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Paul Mackerras committed Aug 29, 2007
1 parent 887c996 commit 719c2b9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion gitk
Original file line number Diff line number Diff line change
Expand Up @@ -6641,8 +6641,9 @@ proc splitarc {p} {
proc addnewchild {id p} {
global allids allparents allchildren idtags nextarc nbmp
global arcnos arcids arctags arcout arcend arcstart archeads growing
global seeds
global seeds allcommits

if {![info exists allcommits]} return
lappend allids $id
set allparents($id) [list $p]
set allchildren($id) {}
Expand Down

0 comments on commit 719c2b9

Please sign in to comment.