Skip to content

Commit

Permalink
Merge branch 'cb/maint-report-mount-point-correctly-in-setup' into maint
Browse files Browse the repository at this point in the history
The filesystem boundary was not correctly reported when .git directory
discovery stopped at a mount point.

By Clemens Buchacher
* cb/maint-report-mount-point-correctly-in-setup:
  properly keep track of current working directory
  • Loading branch information
Junio C Hamano committed May 7, 2012
2 parents 41925d5 + 2565b43 commit 71a3222
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -569,13 +569,15 @@ static const char *setup_nongit(const char *cwd, int *nongit_ok)
return NULL;
}

static dev_t get_device_or_die(const char *path, const char *prefix)
static dev_t get_device_or_die(const char *path, const char *prefix, int prefix_len)
{
struct stat buf;
if (stat(path, &buf))
die_errno("failed to stat '%s%s%s'",
if (stat(path, &buf)) {
die_errno("failed to stat '%*s%s%s'",
prefix_len,
prefix ? prefix : "",
prefix ? "/" : "", path);
}
return buf.st_dev;
}

Expand All @@ -589,7 +591,7 @@ static const char *setup_git_directory_gently_1(int *nongit_ok)
static char cwd[PATH_MAX+1];
const char *gitdirenv, *ret;
char *gitfile;
int len, offset, ceil_offset;
int len, offset, offset_parent, ceil_offset;
dev_t current_device = 0;
int one_filesystem = 1;

Expand Down Expand Up @@ -631,7 +633,7 @@ static const char *setup_git_directory_gently_1(int *nongit_ok)
*/
one_filesystem = !git_env_bool("GIT_DISCOVERY_ACROSS_FILESYSTEM", 0);
if (one_filesystem)
current_device = get_device_or_die(".", NULL);
current_device = get_device_or_die(".", NULL, 0);
for (;;) {
gitfile = (char*)read_gitfile(DEFAULT_GIT_DIR_ENVIRONMENT);
if (gitfile)
Expand All @@ -653,11 +655,12 @@ static const char *setup_git_directory_gently_1(int *nongit_ok)
if (is_git_directory("."))
return setup_bare_git_dir(cwd, offset, len, nongit_ok);

while (--offset > ceil_offset && cwd[offset] != '/');
if (offset <= ceil_offset)
offset_parent = offset;
while (--offset_parent > ceil_offset && cwd[offset_parent] != '/');
if (offset_parent <= ceil_offset)
return setup_nongit(cwd, nongit_ok);
if (one_filesystem) {
dev_t parent_device = get_device_or_die("..", cwd);
dev_t parent_device = get_device_or_die("..", cwd, offset);
if (parent_device != current_device) {
if (nongit_ok) {
if (chdir(cwd))
Expand All @@ -666,14 +669,15 @@ static const char *setup_git_directory_gently_1(int *nongit_ok)
return NULL;
}
cwd[offset] = '\0';
die("Not a git repository (or any parent up to mount parent %s)\n"
die("Not a git repository (or any parent up to mount point %s)\n"
"Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).", cwd);
}
}
if (chdir("..")) {
cwd[offset] = '\0';
die_errno("Cannot change to '%s/..'", cwd);
}
offset = offset_parent;
}
}

Expand Down

0 comments on commit 71a3222

Please sign in to comment.