Skip to content

Commit

Permalink
Do not fall back on vi on dumb terminals.
Browse files Browse the repository at this point in the history
When TERM is set to 'dumb', do not start vi to edit the commit log
message.

Suggested by Amos Waterland.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Feb 5, 2006
1 parent 2d310d8 commit 7334f06
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions git-commit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,14 @@ then
fi
case "$no_edit" in
'')
case "${VISUAL:-$EDITOR},$TERM" in
,dumb)
echo >&2 "Terminal is dumb but no VISUAL nor EDITOR defined."
echo >&2 "Please supply the commit log message using either"
echo >&2 "-m or -F option. A boilerplate log message has"
echo >&2 "been prepared in $GIT_DIR/COMMIT_EDITMSG"
exit 1 ;;
esac
${VISUAL:-${EDITOR:-vi}} "$GIT_DIR/COMMIT_EDITMSG"
;;
esac
Expand Down

0 comments on commit 7334f06

Please sign in to comment.