Skip to content

Commit

Permalink
engine.pl: Fix a recent breakage of the buildsystem generator
Browse files Browse the repository at this point in the history
Commit ade2ca0 (Do not try to remove directories when removing
old links, 2009-10-27) added an expression to a 'test' using an
'-o' or connective. This resulted in the buildsystem generator
mistaking a conditional 'rm' for a linker command. In order to
fix the breakage, we filter out all 'test' commands before then
attempting to identify the commands of interest.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Acked-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ramsay Jones authored and Junio C Hamano committed Jan 22, 2010
1 parent af82559 commit 74cf9bd
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions contrib/buildsystems/engine.pl
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,11 @@ sub parseMakeOutput
}
} while($ate_next);

if ($text =~ /^test /) {
# options to test (eg -o) may be mistaken for linker options
next;
}

if($text =~ / -c /) {
# compilation
handleCompileLine($text, $line);
Expand Down Expand Up @@ -180,9 +185,6 @@ sub parseMakeOutput
# } elsif ($text =~ /generate-cmdlist\.sh/) {
# # command for generating list of commands
#
# } elsif ($text =~ /^test / && $text =~ /|| rm -f /) {
# # commands removing executables, if they exist
#
# } elsif ($text =~ /new locations or Tcl/) {
# # command for detecting Tcl/Tk changes
#
Expand Down

0 comments on commit 74cf9bd

Please sign in to comment.