Skip to content

Commit

Permalink
t/t5538-push-shallow.sh: avoid "test <cond> -a/-o <cond>"
Browse files Browse the repository at this point in the history
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Elia Pinto authored and Junio C Hamano committed Jun 9, 2014
1 parent 7281f36 commit 754b574
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion t/t5538-push-shallow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ EOF
)
'

if test -n "$NO_CURL" -o -z "$GIT_TEST_HTTPD"; then
if test -n "$NO_CURL" || test -z "$GIT_TEST_HTTPD"; then
say 'skipping remaining tests, git built without http support'
test_done
fi
Expand Down

0 comments on commit 754b574

Please sign in to comment.