Skip to content

Commit

Permalink
[PATCH] Use enhanced diff_delta() in the similarity estimator.
Browse files Browse the repository at this point in the history
The diff_delta() interface was extended to reject generating too big a
delta while we were working on the packed GIT archive format.

Take advantage of that when generating delta in the similarity estimator
used in diffcore-rename.c

Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Junio C Hamano authored and Linus Torvalds committed Jun 29, 2005
1 parent e1ddc97 commit 75c660a
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion diffcore-rename.c
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ static int estimate_similarity(struct diff_filespec *src,
*/
void *delta;
unsigned long delta_size, base_size, src_copied, literal_added;
unsigned long delta_limit;
int score;

/* We deal only with regular files. Symlink renames are handled
Expand Down Expand Up @@ -163,9 +164,13 @@ static int estimate_similarity(struct diff_filespec *src,
if (diff_populate_filespec(src, 0) || diff_populate_filespec(dst, 0))
return 0; /* error but caught downstream */

delta_limit = base_size * (MAX_SCORE-minimum_score) / MAX_SCORE;
delta = diff_delta(src->data, src->size,
dst->data, dst->size,
&delta_size, ~0UL);
&delta_size, delta_limit);
if (!delta)
/* If delta_limit is exceeded, we have too much differences */
return 0;

/* A delta that has a lot of literal additions would have
* big delta_size no matter what else it does.
Expand Down

0 comments on commit 75c660a

Please sign in to comment.