Skip to content

Commit

Permalink
git p4 test: sanitize P4CHARSET
Browse files Browse the repository at this point in the history
In the tests, p4d is started without using "internationalized
mode".  Make sure this environment variable is unset, otherwise
a mis-matched user setting would break the tests.  The error
message would be "Unicode clients require a unicode enabled server."

[pw: use unset, add commit text]

Signed-off-by: Kazuki Saitoh <ksaitoh560@gmail.com>
Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
kazuki saitoh authored and Junio C Hamano committed Aug 12, 2013
1 parent 96cb27a commit 7994603
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion t/lib-git-p4.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ P4DPORT=$((10669 + ($testid - $git_p4_test_start)))
P4PORT=localhost:$P4DPORT
P4CLIENT=client
P4EDITOR=:
export P4PORT P4CLIENT P4EDITOR
unset P4CHARSET
export P4PORT P4CLIENT P4EDITOR P4CHARSET

db="$TRASH_DIRECTORY/db"
cli="$TRASH_DIRECTORY/cli"
Expand Down

0 comments on commit 7994603

Please sign in to comment.