Skip to content

Commit

Permalink
fsck.c: fix bogus "empty tree" check
Browse files Browse the repository at this point in the history
ba002f3 (builtin-fsck: move common object checking code to fsck.c) did
more than what it claimed to.  Most notably, it wrongly made an empty tree
object an error by pretending to only move code from fsck_tree() in
builtin-fsck.c to fsck_tree() in fsck.c, but in fact adding a bogus check
to barf on an empty tree.

An empty tree object is _unusual_.  Recent porcelains try reasonably hard
not to let the user create a commit that contains such a tree.  Perhaps
warning about them in git-fsck may have some merit.

HOWEVER.

Being unusual and being errorneous are two quite different things.  This
is especially true now we seem to use the same fsck_$object() code in
places other than git-fsck itself.  For example, receive-pack should not
reject unusual objects, even if it would be a good idea to tighten it to
reject incorrect ones.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Mar 5, 2008
1 parent c95b3ad commit 79b1138
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions fsck.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
o_mode = 0;
o_name = NULL;
o_sha1 = NULL;
if (!desc.size)
return error_func(&item->object, FSCK_ERROR, "empty tree");

while (desc.size) {
unsigned mode;
Expand Down

0 comments on commit 79b1138

Please sign in to comment.