Skip to content

Commit

Permalink
git-stash: use stdout instead of stderr for non error messages
Browse files Browse the repository at this point in the history
Some scripts and libraries check stderr to detect a failing command,
instead of checking the exit code.  Because the output from git-status
is not primarily for machine consumption, it would not hurt to send
these messages to stdout instead and it will make it easier to drive
the command for such callers.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Marco Costalba authored and Junio C Hamano committed Jan 5, 2008
1 parent d6da3cd commit 7c390d9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions git-stash.sh
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ save_stash () {

if no_changes
then
echo >&2 'No local changes to save'
echo 'No local changes to save'
exit 0
fi
test -f "$GIT_DIR/logs/$ref_stash" ||
Expand All @@ -99,7 +99,7 @@ save_stash () {

git update-ref -m "$stash_msg" $ref_stash $w_commit ||
die "Cannot save the current status"
printf >&2 'Saved working directory and index state "%s"\n' "$stash_msg"
printf 'Saved working directory and index state "%s"\n' "$stash_msg"
}

have_stash () {
Expand Down Expand Up @@ -229,7 +229,7 @@ create)
if test $# -eq 0
then
save_stash &&
echo >&2 '(To restore them type "git stash apply")' &&
echo '(To restore them type "git stash apply")' &&
git-reset --hard
else
usage
Expand Down

0 comments on commit 7c390d9

Please sign in to comment.