Skip to content

Commit

Permalink
git-submodule.sh - Remove trailing / from URL if found
Browse files Browse the repository at this point in the history
git clone does not complain if a trailing '/' is included in the origin
URL, but doing so causes resolution of a submodule's URL relative to the
superproject to fail. Regardless of whether git is changed to remove the
trailing / before recording the URL, we should avoid this issue in
submodule as existing repositories can have this problem.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Mark Levedahl authored and Junio C Hamano committed Aug 21, 2008
1 parent ea3594e commit 7c69561
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git-submodule.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ resolve_relative_url ()
remote="${remote:-origin}"
remoteurl=$(git config "remote.$remote.url") ||
die "remote ($remote) does not have a url defined in .git/config"
url="$1"
url="${1%/}"
while test -n "$url"
do
case "$url" in
Expand Down

0 comments on commit 7c69561

Please sign in to comment.