Skip to content

Commit

Permalink
Do not use h_errno after connect(2): the function does not set it
Browse files Browse the repository at this point in the history
Randal L. Schwartz noticed compilation problems on SunOS, which made
me look at the code again. The thing is, h_errno is not used by
connect(2), it is only for functions from netdb.h, like gethostbyname.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Alex Riesen authored and Junio C Hamano committed Jun 16, 2007
1 parent 3e48af3 commit 7cbf2f2
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,10 @@ static int git_tcp_connect_sock(char *host, int flags)
}
if (connect(sockfd, ai->ai_addr, ai->ai_addrlen) < 0) {
saved_errno = errno;
fprintf(stderr, "%s[%d: %s]: net=%s, errno=%s\n",
fprintf(stderr, "%s[%d: %s]: errno=%s\n",
host,
cnt,
ai_name(ai),
hstrerror(h_errno),
strerror(saved_errno));
close(sockfd);
sockfd = -1;
Expand Down Expand Up @@ -315,11 +314,10 @@ static int git_tcp_connect_sock(char *host, int flags)

if (connect(sockfd, (struct sockaddr *)&sa, sizeof sa) < 0) {
saved_errno = errno;
fprintf(stderr, "%s[%d: %s]: net=%s, errno=%s\n",
fprintf(stderr, "%s[%d: %s]: errno=%s\n",
host,
cnt,
inet_ntoa(*(struct in_addr *)&sa.sin_addr),
hstrerror(h_errno),
strerror(saved_errno));
close(sockfd);
sockfd = -1;
Expand Down

0 comments on commit 7cbf2f2

Please sign in to comment.