Skip to content

Commit

Permalink
t/Makefile: pass test opts to valgrind target properly
Browse files Browse the repository at this point in the history
The valgrind target just reinvokes make with GIT_TEST_OPTS
set to "--valgrind". However, it does this using an
environment variable, which means GIT_TEST_OPTS in your
config.mak would override it, and "make valgrind" would
simply run the test suite without valgrind on.

Instead, we should pass GIT_TEST_OPTS on the command-line,
overriding what's in config.mak, and take care to append to
whatever the user has there already.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Jun 17, 2011
1 parent 179aae5 commit 7ef4d6b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion t/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ gitweb-test:
$(MAKE) $(TGITWEB)

valgrind:
GIT_TEST_OPTS=--valgrind $(MAKE)
$(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind"

# Smoke testing targets
-include ../GIT-VERSION-FILE
Expand Down

0 comments on commit 7ef4d6b

Please sign in to comment.