Skip to content

Commit

Permalink
git-bisect termination condition fix.
Browse files Browse the repository at this point in the history
When I munged the original from Linus, which did not terminate
when the last bisect to check happened to be a bad one, to
terminate, I seem to have botched the end result to pick.

Thanks for Sanjoy Mahajan for a good reproduction recipe to
diagnose this.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Aug 4, 2005
1 parent 0dd385c commit 7f47e72
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions git-bisect-script
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ bisect_next() {
rev=$(eval "git-rev-list --bisect $good $bad") || exit
nr=$(eval "git-rev-list $rev $good" | wc -l) || exit
if [ "$nr" -le "1" ]; then
echo "$bad is first bad commit"
git-diff-tree --pretty $bad
echo "$rev is first bad commit"
git-diff-tree --pretty $rev
exit 0
fi
echo "Bisecting: $nr revisions left to test after this"
Expand Down

0 comments on commit 7f47e72

Please sign in to comment.