Skip to content

Commit

Permalink
tests: turn on test-lint by default
Browse files Browse the repository at this point in the history
The test Makefile knows about a few "lint" checks for common
errors. However, they are not enabled as part of "make test"
by default, which means that many people do not bother
running them. Since they are both quick to run and accurate
(i.e., no false positives), there should be no harm in
turning them on and helping submitters catch errors earlier.

We could just set:

  TEST_LINT = test-lint

to enable all tests. But that would be unnecessarily
annoying later on if we add slower or less accurate tests
that should not be part of the default. Instead, we name the
tests individually.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Jan 3, 2013
1 parent 5d41784 commit 81127d7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions t/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ TAR ?= $(TAR)
RM ?= rm -f
PROVE ?= prove
DEFAULT_TEST_TARGET ?= test
TEST_LINT ?= test-lint-duplicates test-lint-executable

# Shell quote;
SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH))
Expand Down

0 comments on commit 81127d7

Please sign in to comment.