Skip to content

Commit

Permalink
archive: allow --exec and --remote without equal sign
Browse files Browse the repository at this point in the history
Allow "--remote repo" and "--exec cmd" in addition to "--remote=repo" and
"--exec=cmd" to make their usage consistent with parameters handled by
parse_options().

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Rene Scharfe authored and Junio C Hamano committed Jul 26, 2008
1 parent f15f736 commit 819b2b5
Showing 1 changed file with 17 additions and 3 deletions.
20 changes: 17 additions & 3 deletions builtin-archive.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ static int run_remote_archiver(const char *remote, int argc,
int fd[2], i, len, rv;
struct child_process *conn;
const char *exec = "git-upload-archive";
int exec_at = 0;
int exec_at = 0, exec_value_at = 0;

for (i = 1; i < argc; i++) {
const char *arg = argv[i];
Expand All @@ -24,15 +24,22 @@ static int run_remote_archiver(const char *remote, int argc,
die("multiple --exec specified");
exec = arg + 7;
exec_at = i;
break;
} else if (!strcmp(arg, "--exec")) {
if (exec_at)
die("multiple --exec specified");
if (i + 1 >= argc)
die("option --exec requires a value");
exec = argv[i + 1];
exec_at = i;
exec_value_at = ++i;
}
}

url = xstrdup(remote);
conn = git_connect(fd, url, exec, 0);

for (i = 1; i < argc; i++) {
if (i == exec_at)
if (i == exec_at || i == exec_value_at)
continue;
packet_write(fd[1], "argument %s\n", argv[i]);
}
Expand Down Expand Up @@ -78,6 +85,13 @@ static const char *extract_remote_arg(int *ac, const char **av)
die("Multiple --remote specified");
remote = arg + 9;
continue;
} else if (!strcmp(arg, "--remote")) {
if (remote)
die("Multiple --remote specified");
if (++ix >= cnt)
die("option --remote requires a value");
remote = av[ix];
continue;
}
if (arg[0] != '-')
no_more_options = 1;
Expand Down

0 comments on commit 819b2b5

Please sign in to comment.