Skip to content

Commit

Permalink
cherry-pick: do not give irrelevant advice when cherry-pick punted
Browse files Browse the repository at this point in the history
If a cherry-pick did not even start because the working tree had local
changes that would overlap with the operation, we shouldn't be advising
the users to resolve conflicts nor to conclude it with "git commit".

Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jay Soffian authored and Junio C Hamano committed Oct 6, 2011
1 parent 9fa8aec commit 82352cb
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions builtin/revert.c
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ static void advise(const char *advice, ...)
va_end(params);
}

static void print_advice(void)
static void print_advice(int show_hint)
{
char *msg = getenv("GIT_CHERRY_PICK_HELP");

Expand All @@ -238,9 +238,11 @@ static void print_advice(void)
return;
}

advise("after resolving the conflicts, mark the corrected paths");
advise("with 'git add <paths>' or 'git rm <paths>'");
advise("and commit the result with 'git commit'");
if (show_hint) {
advise("after resolving the conflicts, mark the corrected paths");
advise("with 'git add <paths>' or 'git rm <paths>'");
advise("and commit the result with 'git commit'");
}
}

static void write_message(struct strbuf *msgbuf, const char *filename)
Expand Down Expand Up @@ -516,7 +518,7 @@ static int do_pick_commit(void)
: _("could not apply %s... %s"),
find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
msg.subject);
print_advice();
print_advice(res == 1);
rerere(allow_rerere_auto);
} else {
if (!no_commit)
Expand Down

0 comments on commit 82352cb

Please sign in to comment.