Skip to content

Commit

Permalink
git-gui: Collapse $env(HOME) to ~/ in recent repositories on Windows
Browse files Browse the repository at this point in the history
Apparently native Tcl/Tk on Windows is using \ as the return value
from [file separator] but [file normalize] on that same system is
using / rather than \ to represent a directory separator.  I really
think that is nuts, but its what is happening.

So we can actually just hardcode our separator to / as all systems
we support (Windows, Mac OS X, UNIX) use /.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Shawn O. Pearce committed Oct 13, 2007
1 parent ba6c761 commit 82dd4e0
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions lib/choose_repository.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,16 @@ constructor pick {} {
$w_recentlist tag conf link \
-foreground blue \
-underline 1
set home "[file normalize $::env(HOME)][file separator]"
set home $::env(HOME)
if {[is_Cygwin]} {
set home [exec cygpath --windows --absolute $home]
}
set home "[file normalize $home]/"
set hlen [string length $home]
foreach p $sorted_recent {
set path $p
if {[string equal -length $hlen $home $p]} {
set p "~[file separator][string range $p $hlen end]"
set p "~/[string range $p $hlen end]"
}
regsub -all "\n" $p "\\n" p
$w_recentlist insert end $p link
Expand Down

0 comments on commit 82dd4e0

Please sign in to comment.