Skip to content

Commit

Permalink
git-gui: Quote git path when starting another gui in a submodule
Browse files Browse the repository at this point in the history
In do_git_gui the path of the git executable has to be put into a
list, otherwise calling it will fail when when spaces are present
in its path.

Reported-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
Jens Lehmann authored and Shawn O. Pearce committed Jan 28, 2010
1 parent cbdaf56 commit 831cc7e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git-gui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2059,7 +2059,7 @@ proc do_git_gui {} {
# -- Always start git gui through whatever we were loaded with. This
# lets us bypass using shell process on Windows systems.
#
set exe [_which git]
set exe [list [_which git]]
if {$exe eq {}} {
error_popup [mc "Couldn't find git gui in PATH"]
} else {
Expand Down

0 comments on commit 831cc7e

Please sign in to comment.