Skip to content

Commit

Permalink
rebase: Fix the detection of fast-forwarding of the current branch to…
Browse files Browse the repository at this point in the history
… upstream.

Previously, a rebasing operation with on a branch that is just tracking
an upstream branch would output a confusing "Nothing to do" due to no
patches being given to git-am.

The test brings the behaviour back into line with that of just before
e646c9c.

Signed-off-by: Robert Shearman <rob@codeweavers.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Robert Shearman authored and Junio C Hamano committed Jul 31, 2006
1 parent b63fafd commit 83c3161
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions git-rebase.sh
Original file line number Diff line number Diff line change
Expand Up @@ -266,22 +266,19 @@ onto=$(git-rev-parse --verify "${onto_name}^0") || exit

# Check if we are already based on $onto, but this should be
# done only when upstream and onto are the same.
if test "$upstream" = "$onto"
mb=$(git-merge-base "$onto" "$branch")
if test "$upstream" = "$onto" && test "$mb" = "$onto"
then
mb=$(git-merge-base "$onto" "$branch")
if test "$mb" = "$onto"
then
echo >&2 "Current branch $branch_name is up to date."
exit 0
fi
echo >&2 "Current branch $branch_name is up to date."
exit 0
fi

# Rewind the head to "$onto"; this saves our current head in ORIG_HEAD.
git-reset --hard "$onto"

# If the $onto is a proper descendant of the tip of the branch, then
# we just fast forwarded.
if test "$mb" = "$onto"
if test "$mb" = "$branch"
then
echo >&2 "Fast-forwarded $branch to $newbase."
exit 0
Expand Down

0 comments on commit 83c3161

Please sign in to comment.