Skip to content

Commit

Permalink
fetch.c: remove an unused variable and dead code.
Browse files Browse the repository at this point in the history
Funnily enough, this variable was never assigned ever since it
was introduced, and has been protecting some code that has never
been executed.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed May 24, 2006
1 parent 4d54815 commit 84c667f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 20 deletions.
20 changes: 3 additions & 17 deletions fetch.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@

const char *write_ref = NULL;

const unsigned char *current_ref = NULL;

int get_tree = 0;
int get_history = 0;
int get_all = 0;
Expand Down Expand Up @@ -205,19 +203,12 @@ static int mark_complete(const char *path, const unsigned char *sha1)
int pull(char *target)
{
unsigned char sha1[20];
int fd = -1;

save_commit_buffer = 0;
track_object_refs = 0;
if (write_ref && current_ref) {
fd = lock_ref_sha1(write_ref, current_ref);
if (fd < 0)
return -1;
}

if (!get_recover) {
if (!get_recover)
for_each_ref(mark_complete);
}

if (interpret_target(target, sha1))
return error("Could not interpret %s as something to pull",
Expand All @@ -227,12 +218,7 @@ int pull(char *target)
if (loop())
return -1;

if (write_ref) {
if (current_ref) {
write_ref_sha1(write_ref, fd, sha1);
} else {
write_ref_sha1_unlocked(write_ref, sha1);
}
}
if (write_ref)
write_ref_sha1_unlocked(write_ref, sha1);
return 0;
}
3 changes: 0 additions & 3 deletions fetch.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ extern int fetch_ref(char *ref, unsigned char *sha1);
/* If set, the ref filename to write the target value to. */
extern const char *write_ref;

/* If set, the hash that the current value of write_ref must be. */
extern const unsigned char *current_ref;

/* Set to fetch the target tree. */
extern int get_tree;

Expand Down

0 comments on commit 84c667f

Please sign in to comment.