Skip to content

Commit

Permalink
Allow help.htmlpath to be a URL prefix
Browse files Browse the repository at this point in the history
Setting this to a URL prefix instead of a path to a local directory allows
git-help --web to work even when HTML docs aren't locally installed, by
pointing the browser at a copy accessible on the web. For example,

    [help]
      format = html
      htmlpath = http://git-scm.com/docs

will use the publicly available documentation on the git homepage.

Signed-off-by: Chris Webb <chris@arachsys.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Chris Webb authored and Junio C Hamano committed Jun 28, 2012
1 parent 89a852e commit 86272b4
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions builtin/help.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,9 +395,11 @@ static void get_html_page_path(struct strbuf *page_path, const char *page)
html_path = system_path(GIT_HTML_PATH);

/* Check that we have a git documentation directory. */
if (stat(mkpath("%s/git.html", html_path), &st)
|| !S_ISREG(st.st_mode))
die(_("'%s': not a documentation directory."), html_path);
if (!strstr(html_path, "://")) {
if (stat(mkpath("%s/git.html", html_path), &st)
|| !S_ISREG(st.st_mode))
die("'%s': not a documentation directory.", html_path);
}

strbuf_init(page_path, 0);
strbuf_addf(page_path, "%s/%s.html", html_path, page);
Expand Down

0 comments on commit 86272b4

Please sign in to comment.