Skip to content

Commit

Permalink
transport: remove git_transport_options.push_cert
Browse files Browse the repository at this point in the history
This field was set in transport_set_option, but never read in the push
code. The push code basically ignores the smart_options field
entirely, and derives its options from the flags arguments to the
push* callbacks. Note that in git_transport_push there are already
several args set from flags that have no corresponding field in
git_transport_options; after this change, push_cert is just like
those.

Signed-off-by: Dave Borowitz <dborowitz@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Dave Borowitz authored and Junio C Hamano committed Aug 19, 2015
1 parent b9299a2 commit 87c0d08
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
3 changes: 0 additions & 3 deletions transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -478,9 +478,6 @@ static int set_git_option(struct git_transport_options *opts,
die("transport: invalid depth option '%s'", value);
}
return 0;
} else if (!strcmp(name, TRANS_OPT_PUSH_CERT)) {
opts->push_cert = !!value;
return 0;
}
return 1;
}
Expand Down
1 change: 0 additions & 1 deletion transport.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ struct git_transport_options {
unsigned check_self_contained_and_connected : 1;
unsigned self_contained_and_connected : 1;
unsigned update_shallow : 1;
unsigned push_cert : 1;
int depth;
const char *uploadpack;
const char *receivepack;
Expand Down

0 comments on commit 87c0d08

Please sign in to comment.