Skip to content

Commit

Permalink
use child_process_init() to initialize struct child_process variables
Browse files Browse the repository at this point in the history
Call child_process_init() instead of zeroing the memory of variables of
type struct child_process by hand before use because the former is both
clearer and shorter.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
René Scharfe authored and Junio C Hamano committed Oct 28, 2014
1 parent fbecd99 commit 8828f29
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion bundle.c
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ int create_bundle(struct bundle_header *header, const char *path,
write_or_die(bundle_fd, "\n", 1);

/* write pack */
memset(&rls, 0, sizeof(rls));
child_process_init(&rls);
argv_array_pushl(&rls.args,
"pack-objects", "--all-progress-implied",
"--stdout", "--thin", "--delta-base-offset",
Expand Down
2 changes: 1 addition & 1 deletion column.c
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ int run_column_filter(int colopts, const struct column_options *opts)
if (fd_out != -1)
return -1;

memset(&column_process, 0, sizeof(column_process));
child_process_init(&column_process);
argv = &column_process.args;

argv_array_push(argv, "column");
Expand Down
2 changes: 1 addition & 1 deletion trailer.c
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ static const char *apply_command(const char *command, const char *arg)
strbuf_replace(&cmd, TRAILER_ARG_STRING, arg);

argv[0] = cmd.buf;
memset(&cp, 0, sizeof(cp));
child_process_init(&cp);
cp.argv = argv;
cp.env = local_repo_env;
cp.no_stdin = 1;
Expand Down
2 changes: 1 addition & 1 deletion transport-helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ static int get_exporter(struct transport *transport,
struct child_process *helper = get_helper(transport);
int i;

memset(fastexport, 0, sizeof(*fastexport));
child_process_init(fastexport);

/* we need to duplicate helper->in because we want to use it after
* fastexport is done with it. */
Expand Down

0 comments on commit 8828f29

Please sign in to comment.