Skip to content

Commit

Permalink
rev-list: remove BISECT_SHOW_TRIED flag
Browse files Browse the repository at this point in the history
Since c99f069 (bisect--helper: remove "--next-vars" option as it is
now useless - 2009-04-21), this flag has always been off. Remove the
flag and all related code.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Nguyễn Thái Ngọc Duy authored and Junio C Hamano committed Feb 28, 2012
1 parent cb8da70 commit 8ba8fe0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
1 change: 0 additions & 1 deletion bisect.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ extern void print_commit_list(struct commit_list *list,

/* bisect_show_flags flags in struct rev_list_info */
#define BISECT_SHOW_ALL (1<<0)
#define BISECT_SHOW_TRIED (1<<1)

struct rev_list_info {
struct rev_info *revs;
Expand Down
12 changes: 1 addition & 11 deletions builtin/rev-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,6 @@ void print_commit_list(struct commit_list *list,
}
}

static void show_tried_revs(struct commit_list *tried)
{
printf("bisect_tried='");
print_commit_list(tried, "%s|", "%s");
printf("'\n");
}

static void print_var_str(const char *var, const char *val)
{
printf("%s='%s'\n", var, val);
Expand All @@ -266,7 +259,7 @@ static int show_bisect_vars(struct rev_list_info *info, int reaches, int all)
struct commit_list *tried;
struct rev_info *revs = info->revs;

if (!revs->commits && !(flags & BISECT_SHOW_TRIED))
if (!revs->commits)
return 1;

revs->commits = filter_skipped(revs->commits, &tried,
Expand Down Expand Up @@ -294,9 +287,6 @@ static int show_bisect_vars(struct rev_list_info *info, int reaches, int all)
printf("------\n");
}

if (flags & BISECT_SHOW_TRIED)
show_tried_revs(tried);

print_var_str("bisect_rev", hex);
print_var_int("bisect_nr", cnt - 1);
print_var_int("bisect_good", all - reaches - 1);
Expand Down

0 comments on commit 8ba8fe0

Please sign in to comment.